[opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)
Boroondas Gupte
sllists at boroon.dasgupta.ch
Thu Dec 2 04:54:52 PST 2010
> On 2010-12-02 04:52:10, Boroondas Gupte wrote:
> >
EDITED TO ADD: (apparently Review Board can't handle comments on comments on lines (sic!) and new comments on lines at the same time)
"The Review-Board diff view conveniently highlights them in red, so they are hard to miss ;-)"
Of course, Review Board can't detect all whitespace mistakes:
- Boroondas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/2/#review10
-----------------------------------------------------------
On 2010-12-01 19:57:24, Oz Linden wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/2/
> -----------------------------------------------------------
>
> (Updated 2010-12-01 19:57:24)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> This review is mostly a first test of reviewboard.
>
> I do have an esthetic dislike for the 'break' statement anywhere but as the end of a case, so I chose to change some instances of break usage that were not justified by any extreme need.
>
>
> This addresses bug storm-606.
> http://jira.secondlife.com/browse/storm-606
>
>
> Diffs
> -----
>
> indra/newview/llappviewer.cpp bf98b026bcb1
>
> Diff: http://codereview.secondlife.com/r/2/diff
>
>
> Testing
> -------
>
> None at all... have not even compiled it yet.
>
>
> Thanks,
>
> Oz
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101202/04205e85/attachment.htm
More information about the opensource-dev
mailing list