[opensource-dev] Review Request: STORM-524 : Refresh L$ balance

Boroondas Gupte sllists at boroon.dasgupta.ch
Thu Dec 9 05:55:34 PST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/6/#review19
-----------------------------------------------------------

Ship it!


Didn't test, but code looks good.


indra/newview/llstatusbar.cpp
<http://codereview.secondlife.com/r/6/#comment8>

    consider to break long comments onto several lines


Other then that, go for it!

- Boroondas


On 2010-12-08 21:59:58, Merov Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/6/
> -----------------------------------------------------------
> 
> (Updated 2010-12-08 21:59:58)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Since the L$ balance can be updated by events outside the viewer entirely (purchase of L$ on web) and since we do not pool or receive notifications for this, I implemented a simple "click to refresh" event on the LLTextBox holding the L$ balance value (proposed by Q in JIRA).
> I modified the tooltip to reflect this new functionality.
> 
> 
> This addresses bug STORM-524.
>     http://jira.secondlife.com/browse/STORM-524
> 
> 
> Diffs
> -----
> 
>   indra/newview/llstatusbar.h 094773a5a314 
>   indra/newview/llstatusbar.cpp 094773a5a314 
>   indra/newview/skins/default/xui/en/panel_status_bar.xml 094773a5a314 
> 
> Diff: http://codereview.secondlife.com/r/6/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Merov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101209/40aca4f4/attachment.htm 


More information about the opensource-dev mailing list