[opensource-dev] Review Request: STORM-524 : Refresh L$ balance

Vadim ProductEngine vsavchuk at productengine.com
Fri Dec 10 00:23:35 PST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/6/#review21
-----------------------------------------------------------


Merov, why do we need those added calls?
And the one in draw() looks suspicious to me: are you sure it won't be ever called, say, 100 times per second?

- Vadim


On 2010-12-09 11:55:40, Merov Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/6/
> -----------------------------------------------------------
> 
> (Updated 2010-12-09 11:55:40)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Since the L$ balance can be updated by events outside the viewer entirely (purchase of L$ on web) and since we do not pool or receive notifications for this, I implemented a simple "click to refresh" event on the LLTextBox holding the L$ balance value (proposed by Q in JIRA).
> I modified the tooltip to reflect this new functionality.
> 
> 
> This addresses bug STORM-524.
>     http://jira.secondlife.com/browse/STORM-524
> 
> 
> Diffs
> -----
> 
>   indra/newview/llbuycurrencyhtml.cpp 25bd6007e3d2 
>   indra/newview/llfloaterbuycurrency.cpp 25bd6007e3d2 
>   indra/newview/llfloaterbuycurrencyhtml.cpp 25bd6007e3d2 
>   indra/newview/llstatusbar.h 25bd6007e3d2 
>   indra/newview/llstatusbar.cpp 25bd6007e3d2 
>   indra/newview/skins/default/xui/en/panel_status_bar.xml 25bd6007e3d2 
> 
> Diff: http://codereview.secondlife.com/r/6/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Merov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101210/fe0900ad/attachment.htm 


More information about the opensource-dev mailing list