[opensource-dev] Review Request: Modify Viewer to statically link to KDU v6.4.1 if available

[Oz Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/3/#review24
-----------------------------------------------------------


Minor cosmetic comments only.... great work, Merov.


indra/llkdu/llimagej2ckdu.cpp
<http://codereview.secondlife.com/r/3/#comment9>

    It's confusing to leave in code that's commented out like this... especially when it includes nested // style comments.



indra/llkdu/llkdumem.h
<http://codereview.secondlife.com/r/3/#comment10>

    More commented out code....
    



indra/llkdu/llkdumem.cpp
<http://codereview.secondlife.com/r/3/#comment11>

    Just delete this... ?
    


- Oz


On 2010-12-03 17:17:14, Merov Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/3/
> -----------------------------------------------------------
> 
> (Updated 2010-12-03 17:17:14)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This rather big patch accomplish the following:
> - makes llkdu public and open source: this contains decompression and compression implementations using the KDU API
> - links the viewer to KDU v6.4.1 statically if USE_KDU set at build time (and assuming you do have a licensed version of Kakadu)
> - links statically to OpenJpeg otherwise
> 
> 
> This addresses bug STORM-151.
>     http://jira.secondlife.com/browse/STORM-151
> 
> 
> Diffs
> -----
> 
>   indra/CMakeLists.txt d94b8cf6891f 
>   indra/cmake/Copy3rdPartyLibs.cmake d94b8cf6891f 
>   indra/cmake/LLKDU.cmake d94b8cf6891f 
>   indra/integration_tests/llui_libtest/CMakeLists.txt d94b8cf6891f 
>   indra/llimage/CMakeLists.txt d94b8cf6891f 
>   indra/llimage/llimage.cpp d94b8cf6891f 
>   indra/llimage/llimagej2c.h d94b8cf6891f 
>   indra/llimage/llimagej2c.cpp d94b8cf6891f 
>   indra/llkdu/CMakeLists.txt PRE-CREATION 
>   indra/llkdu/llimagej2ckdu.h PRE-CREATION 
>   indra/llkdu/llimagej2ckdu.cpp PRE-CREATION 
>   indra/llkdu/llkdumem.h PRE-CREATION 
>   indra/llkdu/llkdumem.cpp PRE-CREATION 
>   indra/newview/CMakeLists.txt d94b8cf6891f 
>   indra/newview/viewer_manifest.py d94b8cf6891f 
>   install.xml d94b8cf6891f 
> 
> Diff: http://codereview.secondlife.com/r/3/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Merov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101214/9f1e9dc4/attachment-0001.htm