[opensource-dev] Review Request: Bug Fix for STORM-776 and STORM-288

[Vadim ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/21/#review28
-----------------------------------------------------------

Ship it!


Looks plausible and works for me.

- Vadim


On 2010-12-15 19:59:24, Wolfpup Lowenhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/21/
> -----------------------------------------------------------
> 
> (Updated 2010-12-15 19:59:24)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This is actually Kitty's patch for STORM-288 but it also corrects the issue listed in STORM-776 as well.
> 
> 
> This addresses bug STORM-776.
>     http://jira.secondlife.com/browse/STORM-776
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt b0689af42a71 
>   indra/newview/llsidepaneliteminfo.h b0689af42a71 
>   indra/newview/llsidepaneliteminfo.cpp b0689af42a71 
> 
> Diff: http://codereview.secondlife.com/r/21/diff
> 
> 
> Testing
> -------
> 
> I have built and tested this locally and was able to fully modify the next person permissions on object that i had full permissions also tested to see if I could set item in inventory for sale and I could.
> 
> Test Viewers for this issue are available here:
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_project-2/rev/216992/index.html
> 
> please test this on mac and linux to verify fix works on all platforms.
> 
> 
> Thanks,
> 
> Wolfpup
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101216/23c5fad5/attachment.htm