[opensource-dev] Review Request: Settings.xml: redundant entries and unnecessary tag

[Jonathan Yap]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/18/#review40
-----------------------------------------------------------



indra/newview/app_settings/settings.xml
<http://codereview.secondlife.com/r/18/#comment20>

    I agree with your observation that the first (and deleted) record has a better Comment string.  But without looking at the code I do not want to go making changes to the wording--my goal was just to eliminate obvious duplicates.



indra/newview/app_settings/settings.xml
<http://codereview.secondlife.com/r/18/#comment21>

    The viewer uses the last record of a repeated group, so it in this case it is using 10.0 (just to be sure I started the viewer and looked).



indra/newview/app_settings/settings.xml
<http://codereview.secondlife.com/r/18/#comment19>

    If I had to make a guess I would say that the 2nd entry for Outbandwidth was the original and that someone copied it up 1 level and put in a comment "Expand render stats display" but forgot to change the associated key.  One could argue that having a F32 is wrong and that it should be an unsigned integer, depending on what units are being used (i.e. a limit of 3.25 makes sense if you are using kb/sec).


- Jonathan


On 2010-12-14 12:39:34, Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/18/
> -----------------------------------------------------------
> 
> (Updated 2010-12-14 12:39:34)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> I wrote two programs that use settings.xml to produce this massive table:
> http://wiki.secondlife.com/wiki/Debug_Settings
> 
> While doing this I found 4 places with duplicate entries and 1 entry that is repeated 4 times.  There is also a pair of unnecessary tags.
> 
> Having these cleaned out would make running my program, and thus updating the wiki table, easier.
> 
> I've erased all but the last entry for these redundant debug settings.
> 
> 
> This addresses bug vwr-24100.
>     http://jira.secondlife.com/browse/vwr-24100
> 
> 
> Diffs
> -----
> 
>   indra/newview/app_settings/settings.xml 46a990f8296f 
> 
> Diff: http://codereview.secondlife.com/r/18/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101216/8df83639/attachment.htm