[opensource-dev] Review Request: VWR-24252: Find Qt4 with find_package on STANDALONE.

[Aleric Inglewood]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/46/
-----------------------------------------------------------

(Updated 2010-12-20 06:19:04.960312)


Review request for Viewer.


Changes
-------

The new version is the same as the previous one, but it adds indra/cmake/FindLLQtWebkit.cmake that was erroneously missing in the previous patch.


Summary (updated)
-------

This patch has only effect on standalone.
It searches for the Qt libs using the cmake provided FindQt4.cmake
and search for llqtwekbit using the new FindLLQtWebkit.cmake
and then uses the resulting LLQTWEBKIT_LIBRARY
and LLQTWEBKIT_INCLUDE_DIR in the right places.

I added an explicit test to check if QTDIR is set, it is set to
the correct value (even LL got this wrong on their wiki, so it's
apparently not obvious): As of Qt 4, Qt is found by calling qmake,
NOT by looking at QTDIR. So, if you set QTDIR then it better be
set to whatever qmake was "found" (using PATH as usual).

Finally, we also need to explicitly pass the Qt plugin libraries
in order to link with them, so part of this patch adds the rules
to do that (the foreach).

Note that if you installed your libs in a non-standard place, then
of course you still have to set LD_LIBRARY_PATH yourself before
running the viewer ;)


This addresses bug VWR-24252.
    http://jira.secondlife.com/browse/VWR-24252


Diffs (updated)
-----

  indra/cmake/FindLLQtWebkit.cmake PRE-CREATION 
  indra/cmake/WebKitLibPlugin.cmake b0689af42a71 
  indra/llplugin/CMakeLists.txt b0689af42a71 
  indra/media_plugins/webkit/CMakeLists.txt b0689af42a71 

Diff: http://codereview.secondlife.com/r/46/diff


Testing
-------

I used this while working on adding plugin support to Imprudence, needing to debug into the Qt libs and llqtwebkit. I added support for multiple versions of llqtwebkit to imprudence (not just the one needed, but also newer versions of llqtwebkit). Needless to say that I needed this patch to work to find my (several) installations of Qt and llqtwebkit.


Thanks,

Aleric

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101220/89abbec3/attachment.htm