[opensource-dev] Review Request: Modify Viewer to statically link to KDU v6.4.1 if available

[Vadim ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/3/#review57
-----------------------------------------------------------

Ship it!


No significant objections. (I didn't actually review llimagej2c.cpp: it would take forever :-))

Tested x86 Linux build with USE_KDU set to ON and OFF. Works fine with the patch I attached to the ticket.


indra/cmake/Copy3rdPartyLibs.cmake
<http://codereview.secondlife.com/r/3/#comment33>

    I didn't quite get why there are FMOD-related changes in this patch.



indra/llkdu/llkdumem.h
<http://codereview.secondlife.com/r/3/#comment31>

    CS: mFirstCompIdx, mNumComponents, etc.


- Vadim


On 2010-12-15 22:21:41, Merov Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/3/
> -----------------------------------------------------------
> 
> (Updated 2010-12-15 22:21:41)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This rather big patch accomplish the following:
> - makes llkdu public and open source: this contains decompression and compression implementations using the KDU API
> - links the viewer to KDU v6.4.1 statically if USE_KDU set at build time (and assuming you do have a licensed version of Kakadu)
> - links statically to OpenJpeg otherwise
> 
> 
> This addresses bug STORM-151.
>     http://jira.secondlife.com/browse/STORM-151
> 
> 
> Diffs
> -----
> 
>   indra/CMakeLists.txt 22c757e8246b 
>   indra/cmake/Copy3rdPartyLibs.cmake 22c757e8246b 
>   indra/cmake/LLKDU.cmake 22c757e8246b 
>   indra/integration_tests/llui_libtest/CMakeLists.txt 22c757e8246b 
>   indra/llimage/CMakeLists.txt 22c757e8246b 
>   indra/llimage/llimage.cpp 22c757e8246b 
>   indra/llimage/llimagej2c.h 22c757e8246b 
>   indra/llimage/llimagej2c.cpp 22c757e8246b 
>   indra/llkdu/CMakeLists.txt PRE-CREATION 
>   indra/llkdu/llimagej2ckdu.h PRE-CREATION 
>   indra/llkdu/llimagej2ckdu.cpp PRE-CREATION 
>   indra/llkdu/llkdumem.h PRE-CREATION 
>   indra/llkdu/llkdumem.cpp PRE-CREATION 
>   indra/newview/CMakeLists.txt 22c757e8246b 
>   indra/newview/viewer_manifest.py 22c757e8246b 
>   install.xml 22c757e8246b 
> 
> Diff: http://codereview.secondlife.com/r/3/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Merov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101220/32af6ee9/attachment-0001.htm