[opensource-dev] Review Request: Update returnability of objects based on new encroachment rules

[Aleric Inglewood]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/56/#review65
-----------------------------------------------------------


I have the feeling that this notion of 'encroachesOwned' is going to cause a lot of trouble in the case of sculptures.
At the very least you should use use an aligned bb that is the minimal bb for anything *visible* of a prim. In the case
of the sculptures this requires a special function to find the min/max coordinates of all the points used. The same
story holds for path cut-off (mega) prims. Ie, if I resize a megaprim (the ONLY way to resize a mega prim is
by using one of those prim torture tricks) then it's very possible one ends up with a prim that is just 1/3 of it's "size".
It wouldn't be fair when a house that clearly ends on ones own parcel is "detected" to encroach another parcel, just
because the viewer code is too lame to take path cutting and sphere dimples etc into account.


- Aleric


On 2010-12-22 09:37:08, Merov Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/56/
> -----------------------------------------------------------
> 
> (Updated 2010-12-22 09:37:08)
> 
> 
> Review request for Viewer and Andrew Meadows.
> 
> 
> Summary
> -------
> 
> The object-vs-parcel overlap test is done by building axis-aligned bounding boxes (AABB) about each prim of the selected objects and then checking for overlap between those boxes and self- and group-owned parcels. 
> 
> 
> This addresses bug STORM-807.
>     http://jira.secondlife.com/browse/STORM-807
> 
> 
> Diffs
> -----
> 
>   indra/llcommon/llversionserver.h fc82190a3f0c 
>   indra/llcommon/llversionviewer.h fc82190a3f0c 
>   indra/llmath/llbbox.h fc82190a3f0c 
>   indra/llmath/llbbox.cpp fc82190a3f0c 
>   indra/llmessage/llregionflags.h fc82190a3f0c 
>   indra/newview/English.lproj/InfoPlist.strings fc82190a3f0c 
>   indra/newview/Info-SecondLife.plist fc82190a3f0c 
>   indra/newview/llviewermenu.cpp fc82190a3f0c 
>   indra/newview/llviewerobject.h fc82190a3f0c 
>   indra/newview/llviewerobject.cpp fc82190a3f0c 
>   indra/newview/llviewerparceloverlay.h fc82190a3f0c 
>   indra/newview/llviewerparceloverlay.cpp fc82190a3f0c 
>   indra/newview/llviewerregion.h fc82190a3f0c 
>   indra/newview/llviewerregion.cpp fc82190a3f0c 
>   indra/newview/res/viewerRes.rc fc82190a3f0c 
>   indra/newview/skins/default/xui/en/menu_viewer.xml fc82190a3f0c 
> 
> Diff: http://codereview.secondlife.com/r/56/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Merov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101222/8900192e/attachment.htm