[opensource-dev] Review Request: The world map can point to the wrong URL

[Vadim ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/61/#review76
-----------------------------------------------------------


Looks good overall, I only have a minor point.


indra/newview/llstartup.cpp
<http://codereview.secondlife.com/r/61/#comment43>

    Frankly speaking, I'm not a fan of adding another setting to only use it as a global variable.
    
    I would search for a more proper way, maybe adding get/setMapServerURL() methods to LLWorldMap.
    Perhaps a person more familiar with the world map code than me would suggest a better approach.


- Vadim


On 2010-12-22 22:15:00, Merov Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/61/
> -----------------------------------------------------------
> 
> (Updated 2010-12-22 22:15:00)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Implements the processing of map-server-url correctly so not to overwrite the default value (which can still be useful if a grid does not implement map-server-url).
> 
> 
> This addresses bug STORM-805.
>     http://jira.secondlife.com/browse/STORM-805
> 
> 
> Diffs
> -----
> 
>   indra/newview/app_settings/settings.xml 5d69e36a53ee 
>   indra/newview/llstartup.cpp 5d69e36a53ee 
>   indra/newview/llworldmipmap.cpp 5d69e36a53ee 
> 
> Diff: http://codereview.secondlife.com/r/61/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Merov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101223/1d967d91/attachment.htm