[opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu
Oz Linden
oz at lindenlab.com
Thu Dec 23 12:01:27 PST 2010
> On 2010-12-23 06:46:09, Vadim ProductEngine wrote:
> > indra/llkdu/llimagej2ckdu.h, line 58
> > <http://codereview.secondlife.com/r/63/diff/1/?file=255#file255line58>
> >
> > Please add a comment that these methods aren't actually public, i.e. were made public only to be called from unit tests.
A better way to make internals available to a unit test is to make the unit test class a friend of the class it is testing. This makes the intent clear, and leaves object internals properly hidden.
- Oz
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/63/#review79
-----------------------------------------------------------
On 2010-12-22 23:51:18, Merov Linden wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/63/
> -----------------------------------------------------------
>
> (Updated 2010-12-22 23:51:18)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> Unit tests addition:
> - add tests for llkdu
> - turned back on and fix unit tests for llimage
> - turned back on and fix unit tests for llworldmap and llworldmipmap
>
>
> This addresses bug STORM-744.
> http://jira.secondlife.com/browse/STORM-744
>
>
> Diffs
> -----
>
> indra/llimage/CMakeLists.txt 5d69e36a53ee
> indra/llimage/tests/llimageworker_test.cpp 5d69e36a53ee
> indra/llkdu/CMakeLists.txt 5d69e36a53ee
> indra/llkdu/llimagej2ckdu.h 5d69e36a53ee
> indra/llkdu/tests/llimagej2ckdu_test.cpp PRE-CREATION
> indra/newview/CMakeLists.txt 5d69e36a53ee
> indra/newview/tests/llworldmap_test.cpp 5d69e36a53ee
> indra/newview/tests/llworldmipmap_test.cpp 5d69e36a53ee
>
> Diff: http://codereview.secondlife.com/r/63/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Merov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101223/c7cd6216/attachment.htm
More information about the opensource-dev
mailing list