[opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

[Aleric Inglewood]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/63/#review78
-----------------------------------------------------------


Huh - I wrote this a long time ago (before the others commented)... apparently I forgot to click on "Publish Review"!



indra/llkdu/llimagej2ckdu.h
<http://codereview.secondlife.com/r/63/#comment45>

    This feels wrong. Those functions are implementations of the base class interface, they are called by the base class: if they need to be called directly, something is wrong.
    
    If this is made public because the unit test needs access, then instead add a friend for the unit test class.
    


- Aleric


On 2010-12-22 23:51:18, Merov Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/63/
> -----------------------------------------------------------
> 
> (Updated 2010-12-22 23:51:18)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Unit tests addition:
> - add tests for llkdu
> - turned back on and fix unit tests for llimage
> - turned back on and fix unit tests for llworldmap and llworldmipmap
> 
> 
> This addresses bug STORM-744.
>     http://jira.secondlife.com/browse/STORM-744
> 
> 
> Diffs
> -----
> 
>   indra/llimage/CMakeLists.txt 5d69e36a53ee 
>   indra/llimage/tests/llimageworker_test.cpp 5d69e36a53ee 
>   indra/llkdu/CMakeLists.txt 5d69e36a53ee 
>   indra/llkdu/llimagej2ckdu.h 5d69e36a53ee 
>   indra/llkdu/tests/llimagej2ckdu_test.cpp PRE-CREATION 
>   indra/newview/CMakeLists.txt 5d69e36a53ee 
>   indra/newview/tests/llworldmap_test.cpp 5d69e36a53ee 
>   indra/newview/tests/llworldmipmap_test.cpp 5d69e36a53ee 
> 
> Diff: http://codereview.secondlife.com/r/63/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Merov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101224/3898267b/attachment-0001.htm