[opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

[Vadim ProductEngine]

> On 2010-12-24 10:55:28, Vadim ProductEngine wrote:
> > indra/newview/llpanelmaininventory.cpp, line 509
> > <http://codereview.secondlife.com/r/65/diff/1/?file=274#file274line509>
> >
> >     This line can now be removed at all.
> 
> Jonathan Yap wrote:
>     Line 509 on the left is removed; it might be that the diff display is slightly confused about this matter.  Not sure what a lighter color of pink means.

I meant the line on the right: no need to set visibility to true because it's the default value.
(I tried removing that line and nothing changed)


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/65/#review85
-----------------------------------------------------------


On 2010-12-23 13:25:31, Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/65/
> -----------------------------------------------------------
> 
> (Updated 2010-12-23 13:25:31)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This change enables the "+" menu in Inventory/Recent
> It grays out "New Folder" in this menu
> It enables identical menu entries when you right click on an inventory item.
> 
> Question:
>  Is graying out "New Folder" best done where I am doing it now -- in 
> llpanelmaininventory.cpp / LLPanelMainInventory::onAddButtonClick()
> 
> 
> This addresses bug storm-737.
>     http://jira.secondlife.com/browse/storm-737
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt e843e274fa58 
>   indra/newview/llinventorybridge.cpp e843e274fa58 
>   indra/newview/llpanelmaininventory.cpp e843e274fa58 
> 
> Diff: http://codereview.secondlife.com/r/65/diff
> 
> 
> Testing
> -------
> 
> I opened up Inventory/My Inventory and used all the "New xxx" options for both right clicking on an inventory item and also from the "+" menu.
> 
> I then changed to the Recent tab and performed the same steps.
> 
> New items were created as expected, except "New Folder" was not an option via either method when the Recent tab was active.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101227/0850627d/attachment.htm