[opensource-dev] Review Request: VWR-20879 FTBFS: find_vc_dir() fails with Visual Studio Express

Merov Linden merov at lindenlab.com
Mon Dec 27 22:23:31 PST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/66/#review98
-----------------------------------------------------------

Ship it!


Seems correct though I could test with Express. At least, that shouldn't change anything for VS.

- Merov


On 2010-12-27 04:32:58, Robin Cornelius wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/66/
> -----------------------------------------------------------
> 
> (Updated 2010-12-27 04:32:58)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Add VCExpress as a search option in find_vc_dir() to enable the build process to complete even when using Visual Studio Express
> 
> 
> This addresses bug VWR-20879.
>     http://jira.secondlife.com/browse/VWR-20879
> 
> 
> Diffs
> -----
> 
>   indra/lib/python/indra/util/test_win32_manifest.py 279f35982a1a 
> 
> Diff: http://codereview.secondlife.com/r/66/diff
> 
> 
> Testing
> -------
> 
> Built viewer development using VCExpress 2005 to completion/installer generation sucessfully.
> 
> 
> Thanks,
> 
> Robin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101228/b826b787/attachment.htm 


More information about the opensource-dev mailing list