[opensource-dev] Potential inventory problem?

[John Hurliman]

Finally nailed this one down. If you have items in your inventory that have
completely empty permissions (basemask 0, everyonemask 0, currentmask 0,
etc) the viewer will freeze when you open the texture picker dialog. This
appears to affect all released versions of the viewer. The next obvious
question is whether this can be triggered by giving someone a bad item
either directly or through a group attachment or notecard.

I put a sanity check in my OpenSim connector code to look for the red flag
of items with a basemask of 0.

John

On Mon, Mar 8, 2010 at 6:28 PM, John Hurliman <jhurliman at jhurliman.org>wrote:

> That certainly sounds like the symptoms I'm seeing. One of my two CPUs is
> pegged, memory allocation for the Snowglobe process is all over the place
> (jumping up and down by 10s or 100s of MB at a time), and the hang seems to
> be indefinite. I haven't left it for more than three minutes, but by that
> time the server has decided you are timed out since the client isn't sending
> any network traffic.
>
> We also just confirmed that the current OpenSim master isn't triggering
> this bug, so it's a subtle difference between what the stock OpenSim
> inventory connector is doing and what mine is doing. It would be really nice
> to know what that difference is, but it sounds like Qarl wasn't sure either.
> I just found out I'm sending folders with Version = 0 and I'm told that
> version should start at 1. I fixed that and it hasn't resolved the issue,
> but I'll keep plugging away.
>
> John
>
>
> On Mon, Mar 8, 2010 at 4:23 PM, Nexii Malthus <nexiim at googlemail.com>wrote:
>
>> Ah, the comment by Qarl Linden in the JIRA issue nails the issue for that
>> specific freeze bug:
>> "i'm not sure how our external svn is configured - but i can explain the
>> root of the problem. it's with our memory allocator (malloc/new/etc.) we
>> switched back at 1.21, and the behavior of the inventory system seemed to
>> trigger some kind of horrible worst-case scenario. with my demo above, i
>> switched to dmalloc. for the real fix in 1.23, we invoked some windows magic
>> to improve the allocator performance."
>>
>> Might that help for this bug?
>>
>> - Nexii
>>
>> On Tue, Mar 9, 2010 at 12:19 AM, Nexii Malthus <nexiim at googlemail.com>wrote:
>>
>>> It does happen on the SL grid. At least it did for a long while, I have
>>> admit I use the texture picker not that often these days, but it has burned
>>> me pretty badly.
>>>
>>> How bad is the freeze? How long is it?
>>>
>>> Edit: Found this JIRA, might be relevant to the problem I think, the
>>> freeze bug used to exist in 1.21 and 1.22 and was fixed with 1.23.
>>> http://jira.secondlife.com/browse/VWR-8818
>>>
>>>
>>> - Nexii
>>>
>>>
>>> On Mon, Mar 8, 2010 at 10:33 PM, Rob Nelson <
>>> nexisentertainment at gmail.com> wrote:
>>>
>>>> Hahaha, I remember back when Open Grid Services was written in PHP;  I
>>>> still have it on my webserver somewhere.  I think I submitted a patch to
>>>> you guys several years ago (regarding a SQL injection exploit) where I
>>>> accidentally left in a bunch of cursing and racial slurs.
>>>>
>>>> If I contribute again, I think I'll be a little more careful.
>>>>
>>>> Also, I'll take a peek into what's causing that problem;  I'm having to
>>>> redo the UI in Lua anyway, so I may as well figure out what is causing
>>>> your issues.
>>>>
>>>> Fred Rookstown
>>>>
>>>> On Mon, 2010-03-08 at 11:17 -0800, John Hurliman wrote:
>>>> > Yes, I'm trying to push out the first release of a set of PHP grid
>>>> > services for OpenSim and the texture picker freeze bug is a
>>>> > showstopper. It obviously doesn't happen on SLGrid and it wasn't
>>>> > happening in the past with OpenSim. A packet trace didn't show
>>>> > anything interesting (doesn't appear to be triggered by a specific
>>>> > packet at all). My current guess is that the client is making a bad
>>>> > assumption about information the server sent earlier on. It might have
>>>> > to do with the library since I am not sending a library skeleton at
>>>> > the moment.
>>>> >
>>>> > Any other clues on the freezing issue would be much appreciated. The
>>>> > warning is more of a curiosity but it could uncover another hidden
>>>> > expectation the open source server software is not meeting.
>>>> >
>>>> > John
>>>> >
>>>> > On Mon, Mar 8, 2010 at 9:21 AM, Nexii Malthus <nexiim at googlemail.com>
>>>> > wrote:
>>>> >         Happens just as well on any grid. I'm just as confused as
>>>> >         anyone here what this error message means, but this was
>>>> >         brought up before and I vaguely remember a linden saying that
>>>> >         wasn't the source of the lag problems related to inventory.
>>>> >
>>>> >
>>>> >         Are you trying to track down the texture picker freezing bug?
>>>> >
>>>> >
>>>> >         - Nexii
>>>> >
>>>> >
>>>> >         On Mon, Mar 8, 2010 at 12:45 AM, John Hurliman
>>>> >         <jhurliman at jhurliman.org> wrote:
>>>> >
>>>> >
>>>> >                 When logging into OpenSim with Snowglobe I see a lot
>>>> >                 (dozens) of these messages in the log file:
>>>> >
>>>> >                 2010-03-08T00:33:18Z WARNING:
>>>> >                 LLInventoryPanel::modelChanged:
>>>> >                 d24c5c7b-4d64-45eb-9286-91fb0f307b24 is in model and
>>>> >                 in view, but STRUCTURE flag not set
>>>> >
>>>> >                 What does this message mean? Am I sending inventory
>>>> >                 items in the wrong order, or with missing data? I'm
>>>> >                 trying to track down a client freezing bug in
>>>> >                 Snowglobe and the official viewer that might be
>>>> >                 related to inventory, and found this.
>>>> >
>>>> >                 John
>>>> >
>>>> >
>>>> >                 _______________________________________________
>>>> >                 Policies and (un)subscribe information available here:
>>>> >                 http://wiki.secondlife.com/wiki/OpenSource-Dev
>>>> >                 Please read the policies before posting to keep
>>>> >                 unmoderated posting privileges
>>>> >
>>>> >
>>>> >
>>>> >
>>>> > _______________________________________________
>>>> > Policies and (un)subscribe information available here:
>>>> > http://wiki.secondlife.com/wiki/OpenSource-Dev
>>>> > Please read the policies before posting to keep unmoderated posting
>>>> privileges
>>>>
>>>>
>>>> _______________________________________________
>>>> Policies and (un)subscribe information available here:
>>>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>>>> Please read the policies before posting to keep unmoderated posting
>>>> privileges
>>>>
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20100309/77979c6c/attachment.htm