[opensource-dev] (standalone/64-bit) build issues with Mesh viewer source code (and fixes for some of them. Yay!)

[Boroondas Gupte]

 So ... I've been busy during the weeking poking the mesh viewer source
code with a stick g++ and can report some results. It seems quite some
of the issues were (re)introduced by mistakes in merge conflict
resolution. Some others are new. Here are the one's I've filed issues
for already:


      CTS-314 <https://jira.secondlife.com/browse/CTS-314>: Fix of
      VWR-20810 / SNOW-503 (Quote EXE_STAGING_DIR to prevent it failing
      with some paths) lost in merge

    * VWR-20810 <https://jira.secondlife.com/browse/VWR-20810> was fixed
      at b987077e9bbb
      <http://bitbucket.org/lindenlab/viewer-development/changeset/b987077e9bbb>,
      but it looks like the fix got lost in the merge at 538a49313042
      <http://bitbucket.org/lindenlab/mesh-development/changeset/538a49313042>.
    * Re-fixed
    * Ready for review


      CTS-315 <https://jira.secondlife.com/browse/CTS-315>:
      -march=pentium4 may not be used for 64bit builds

    * Started discussion
      <https://lists.secondlife.com/pipermail/opensource-dev/2010-October/thread.html#4338>
      on the mailing list about how to fix this correctly
    * Until that's decided, work around with

      sed '175 s/-march=pentium4 //' -i indra/cmake/00-Common.cmake

      when building 64-bit.


      CTS-318 <https://jira.secondlife.com/browse/CTS-318>: Fix of
      VWR-20809 / SNOW-504 (Do not depend on stage_thirds_party_libs for
      a standalone build.) lost in merge

    * VWR-20809 <https://jira.secondlife.com/browse/VWR-20809> was fixed
      at c5ddd1e361ae
      <http://bitbucket.org/lindenlab/viewer-development/changeset/c5ddd1e361ae>
      , but it looks like the fix got lost in the merge at 538a49313042
      <http://bitbucket.org/lindenlab/mesh-development/changeset/538a49313042>.
    * Re-fixed
    * Ready for review


      CTS-319 <https://jira.secondlife.com/browse/CTS-319>: Fix of
      VWR-20670 / SNOW-506 (Protection on LLInstanceTracker base in
      LLEventTimer needs to be public for gcc >4.1) lost in merge

    * VWR-20670 <https://jira.secondlife.com/browse/VWR-20670> was fixed
      at 20860bbd5cae
      <http://bitbucket.org/lindenlab/viewer-development/changeset/20860bbd5cae>,
      but it looks like the fix got lost in the merge at ad384ab52275
      <http://bitbucket.org/lindenlab/mesh-development/changeset/ad384ab52275>.
    * Re-fixed
    * Ready for review


      CTS-320 <https://jira.secondlife.com/browse/CTS-320>: use system
      zlib for standalone

    * Fixed, using the same pattern as already used elsewhere in the code
          o Noticed some mistakes in the fix and corrected those
    * Ready for review


      CTS-323 <https://jira.secondlife.com/browse/CTS-323>: Don't cast
      pointers to U32

    * Fixed by using uintptr_t instead.
          o This type isn't part of the current C++ standard (might
            become part of the next), but it's already used elsewhere in
            the code, so I assume all of our build platforms support it.
    * Ready for review



Now I'm stuck at where it won't find the new libraries
<https://lists.secondlife.com/pipermail/opensource-dev/2010-October/004337.html>,
even when I build and install them. I guess some CMake glue for
standalone is still missing. (Or maybe I should just wait for auto-build?)

Also, when tests are enabled, one of them errors out. That's right, it's
*not even failing*. :-P

    Running: /usr/bin/python ${SRC_DIR}/indra/llmessage/tests/test_llsdmessage_peer.py ${BUILD_DIR}/llmessage/INTEGRATION_TEST_llsdmessage
    Unit test group_started name=llsdmessage
    Failed to catch N11LLEventPump11DupPumpNameE
    Failure running: /usr/bin/python ${SRC_DIR}/indra/llmessage/tests/test_llsdmessage_peer.py ${BUILD_DIR}/llmessage/INTEGRATION_TEST_llsdmessage
    Error: 245
    make[2]: *** [llmessage/INTEGRATION_TEST_llsdmessage] Error 245
    make[1]: *** [llmessage/CMakeFiles/INTEGRATION_TEST_llsdmessage.dir/all] Error 2
    make: *** [all] Error 2

Wolfpup observed that INTEGRATION_TEST_llcapabilitylistener also has
runtime issues.

Cheers,
Boroondas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101025/13143921/attachment.htm