[opensource-dev] Second Pair of eyes needed!

[Mike Monkowski]

You're half right :-)
Change the other "LLFILE* fptr =" to "fptr =" as well.

Mike

Tiggs Linden wrote:
> You're shadowing fptr in the last if clause:
>   if (!fptr)
>        {
>                LLFILE* fptr = LLFile::fopen(oldLogFileName(filename),
> "r");    /*Flawfinder: ignore*/
>                LL_INFOS("") << "Old    :" << file_name << LL_ENDL;
>                if (!fptr)
>                {
>                        LLFILE* fptr =
> LLFile::fopen(ndsLogFileName(file_name), "r");          /*Flawfinder:
> ignore*/
>                        LL_INFOS("") << "Orginal:" << file_name << LL_ENDL;
>                        if (!fptr) return;      //No previous conversation
> with this name.
>                }
>        }
> 
> Change that to:
> 
>   if (!fptr)
>        {
>               fptr = LLFile::fopen(oldLogFileName(filename),
> "r");/*Flawfinder: ignore*/
>                LL_INFOS("") << "Old    :" << file_name << LL_ENDL;
>                if (!fptr)
>                {
>                        LLFILE* fptr =
> LLFile::fopen(ndsLogFileName(file_name), "r");          /*Flawfinder:
> ignore*/
>                        LL_INFOS("") << "Orginal:" << file_name << LL_ENDL;
>                        if (!fptr) return;      //No previous conversation
> with this name.
>                }
>        }