[opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

[Lance Corrimal]

> On March 17, 2011, 11:46 a.m., Jonathan Yap wrote:
> > The code that creates a ring @ 100 meters has been removed and I changed the mystery constant 20.0 to CHAT_NORMAL_RADIUS.  Struggling with the diff hence that part is not updated.
> 
> Lance Corrimal wrote:
>     I found both rings quite useful.
>     oh and btw I think the rings shouldn't be blue. At least not for me to find them useful... for sailing.
>

here's a little snapshot taken with a slightly modified version of this patch in my "work in progress" version of the dolphin viewer.
observe the minimap.

http://www.flickr.com/photos/lance_corrimal/5540695054/


- Lance


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/197/#review480
-----------------------------------------------------------


On March 12, 2011, 8 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/197/
> -----------------------------------------------------------
> 
> (Updated March 12, 2011, 8 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range.
> 
> By default the range ring is off.
> 
> To turn it on you right click on the mini-map and pick the menu entry "Range Ring".
> 
> 
> This addresses bug Storm-1068.
>     http://jira.secondlife.com/browse/Storm-1068
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt aed94e854443 
>   indra/newview/app_settings/settings.xml aed94e854443 
>   indra/newview/llnetmap.h aed94e854443 
>   indra/newview/llnetmap.cpp aed94e854443 
>   indra/newview/skins/default/colors.xml aed94e854443 
>   indra/newview/skins/default/xui/en/menu_mini_map.xml aed94e854443 
> 
> Diff: http://codereview.secondlife.com/r/197/diff
> 
> 
> Testing
> -------
> 
> Tested with another avatar.  When they are outside the ring they cannot see my local chat and when they are inside it they can, so the ring's radius is set correctly.
> 
> Flew over various types of land to make sure my color choice (blue @10%) was always visible.
> 
> Enabled range ring, logged out and back on; range ring is still present on mini-map.
> 
> Panned mini-map, range ring remains centered over avatar.
> 
> Used mouse wheel to zoom in and out as far as possible.  Size of range ring varied with change in zoom level.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110401/5d90d62a/attachment.htm