[opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

[Jonathan Yap]

> On March 30, 2011, 3:16 p.m., Boroondas Gupte wrote:
> > indra/llui/lllineeditor.cpp, lines 2294-2297
> > <http://codereview.secondlife.com/r/244/diff/2/?file=1361#file1361line2294>
> >
> >     ... this simple setter isn't implemented right at the declaration (i.e. in indra/llui/lllineeditor.h)?

Unfortunately this identical change is also in Storm-1094 and I don't want to make the MM crazy.  As I do not have much internet at the moment if someone would like to adjust both of these jiras to match please do so, but I don't see that this is a showstopper if not addressed.


> On March 30, 2011, 3:16 p.m., Boroondas Gupte wrote:
> > indra/newview/llbottomtray.cpp, lines 554-555
> > <http://codereview.secondlife.com/r/244/diff/2/?file=1362#file1362line554>
> >
> >     If font isn't used later, this could be written as
> >     	mNearbyChatBar->getChatBox()->setFont(LLViewerChat::getChatFont());
> >     
> >     (Not sure which variant is more readable.)

I was doing a bit of code stealing of my changes in other files, hence the two lines made more sense in this instance.


> On March 30, 2011, 3:16 p.m., Boroondas Gupte wrote:
> > indra/newview/llviewerchat.cpp, lines 38-39
> > <http://codereview.secondlife.com/r/244/diff/2/?file=1367#file1367line38>
> >
> >     Whatever the reason for that comment is, I guess the idea is that you put new members below it, not above.
> >     
> >     Also, should this be initialized to null here ...

This was fixed as well.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/244/#review523
-----------------------------------------------------------


On March 30, 2011, 5:43 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/244/
> -----------------------------------------------------------
> 
> (Updated March 30, 2011, 5:43 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
>  Chat preferences > font size should increase size of input text in the chat box
> 
> 
> This addresses bug STORM-1095.
>     http://jira.secondlife.com/browse/STORM-1095
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 65ff7415f171 
>   indra/llui/lllineeditor.h 65ff7415f171 
>   indra/llui/lllineeditor.cpp 65ff7415f171 
>   indra/newview/llbottomtray.cpp 65ff7415f171 
>   indra/newview/llfloaterpreference.cpp 65ff7415f171 
>   indra/newview/llnearbychatbar.h 65ff7415f171 
>   indra/newview/llnearbychatbar.cpp 65ff7415f171 
>   indra/newview/llviewerchat.h 65ff7415f171 
>   indra/newview/llviewerchat.cpp 65ff7415f171 
> 
> Diff: http://codereview.secondlife.com/r/244/diff
> 
> 
> Testing
> -------
> 
> Change font size in preferences and see
> 1) Font size in chat input box changes to new size immediately
> 2) Font size is set to selected size when viewer is restarted
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110404/5611bf2f/attachment.htm