[opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

[Ricky]

ok, this is getting annoying.  Any idea why I am having issues posting to
the review?

Ricky
Cron Stardust

On Mon, Apr 4, 2011 at 4:48 PM, Cron Stardust <kf6kjg at gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/199/
>
> Huh.. long winded speech became dust on pressing publish...  Here goes again:
>
>
> - Cron
>
> On April 4th, 2011, 10:34 a.m., Cron Stardust wrote:
>   Review request for Viewer.
> By Cron Stardust.
>
> *Updated April 4, 2011, 10:34 a.m.*
> Description
>
> I looking at the code, trying to find out where/how to add a new feature, when I tripped across one of these and it lit my mental warning bells off.  Vector distance comparisons should, IMHO, always be done squared.  So I did some greppin, manual analysis, and some careful modification, and here's the result.
>
>   Testing
>
> Compiled a test viewer and used it, undertaking some of my normal activities.  Results felt good, but are currently anecdotal.  Any suggestions on how to properly measure this (or even some actual measurement from those already instrumented to measure these things,) would be great!
>
>   *Bugs: * VWR-25126 <http://jira.secondlife.com/browse/VWR-25126>
> Diffs
>
>    - doc/contributions.txt (344d4c6d7d7e)
>    - indra/llcharacter/llbvhloader.cpp (344d4c6d7d7e)
>    - indra/llcommon/indra_constants.h (344d4c6d7d7e)
>    - indra/llmath/tests/llbbox_test.cpp (344d4c6d7d7e)
>    - indra/newview/llagent.cpp (344d4c6d7d7e)
>    - indra/newview/llfloaterchat.cpp (344d4c6d7d7e)
>    - indra/newview/llhudeffectlookat.cpp (344d4c6d7d7e)
>    - indra/newview/llhudeffectpointat.cpp (344d4c6d7d7e)
>    - indra/newview/llmaniprotate.cpp (344d4c6d7d7e)
>    - indra/newview/llmanipscale.cpp (344d4c6d7d7e)
>    - indra/newview/llnetmap.cpp (344d4c6d7d7e)
>    - indra/newview/llpanelpeople.cpp (344d4c6d7d7e)
>    - indra/newview/llselectmgr.cpp (344d4c6d7d7e)
>    - indra/newview/llspeakers.cpp (344d4c6d7d7e)
>    - indra/newview/llviewerchat.cpp (344d4c6d7d7e)
>    - indra/newview/llviewermessage.cpp (344d4c6d7d7e)
>    - indra/newview/llviewerparceloverlay.cpp (344d4c6d7d7e)
>    - indra/newview/llvoicevivox.cpp (344d4c6d7d7e)
>    - indra/newview/llworld.cpp (344d4c6d7d7e)
>
> View Diff <http://codereview.secondlife.com/r/199/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110404/1ed4a01b/attachment-0001.htm