[opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

[Vadim ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/244/#review556
-----------------------------------------------------------



indra/newview/llnearbychatbar.h
<http://codereview.secondlife.com/r/244/#comment491>

    Avoid redundant changes.



indra/newview/llnearbychatbar.h
<http://codereview.secondlife.com/r/244/#comment490>

    Remove the class prefix: it may cause compilation problems on Linux.



indra/newview/llnearbychatbar.cpp
<http://codereview.secondlife.com/r/244/#comment489>

    CS: "if ("



indra/newview/llviewerchat.h
<http://codereview.secondlife.com/r/244/#comment487>

    * Readability: please separate type definitions from methods.
    * CS: Inconsistent naming. Should be something like font_change_signal_t.



indra/newview/llviewerchat.h
<http://codereview.secondlife.com/r/244/#comment488>

    * Memory leak? Seems to be never deleted.
    * Why pointer?
    * Move to private section.
    * CS: rename to sFontChangedSignal.


- Vadim


On March 30, 2011, 5:43 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/244/
> -----------------------------------------------------------
> 
> (Updated March 30, 2011, 5:43 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
>  Chat preferences > font size should increase size of input text in the chat box
> 
> 
> This addresses bug STORM-1095.
>     http://jira.secondlife.com/browse/STORM-1095
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 65ff7415f171 
>   indra/llui/lllineeditor.h 65ff7415f171 
>   indra/llui/lllineeditor.cpp 65ff7415f171 
>   indra/newview/llbottomtray.cpp 65ff7415f171 
>   indra/newview/llfloaterpreference.cpp 65ff7415f171 
>   indra/newview/llnearbychatbar.h 65ff7415f171 
>   indra/newview/llnearbychatbar.cpp 65ff7415f171 
>   indra/newview/llviewerchat.h 65ff7415f171 
>   indra/newview/llviewerchat.cpp 65ff7415f171 
> 
> Diff: http://codereview.secondlife.com/r/244/diff
> 
> 
> Testing
> -------
> 
> Change font size in preferences and see
> 1) Font size in chat input box changes to new size immediately
> 2) Font size is set to selected size when viewer is restarted
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110405/2dd81351/attachment-0001.htm