[opensource-dev] Review Request: STORM-610 : Changes to Environment Editor: water color change is not saved

[Merov Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/254/
-----------------------------------------------------------

Review request for Viewer.


Summary
-------

This is a rework of Vadim's original fix plus additional fixes for initialization of water fog color issues that mysteriously show only on Mac. Compared to Vadim's fix, I just added init of mPrevFogColor, separated the various affectations and, critically, changed the default color in settings.xml (the color channel values are normalized between 0 and 1).


This addresses bug STORM-610.
    http://jira.secondlife.com/browse/STORM-610


Diffs
-----

  indra/newview/app_settings/settings.xml 33ca961b0870 
  indra/newview/llwaterparammanager.h 33ca961b0870 
  indra/newview/llwaterparammanager.cpp 33ca961b0870 

Diff: http://codereview.secondlife.com/r/254/diff


Testing
-------

Built and tested on Mac. The issue I reported was fixed.


Thanks,

Merov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110406/d6b6674e/attachment.htm