[opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

Vadim ProductEngine vsavchuk at productengine.com
Thu Apr 7 16:20:25 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/255/
-----------------------------------------------------------

Review request for Viewer.


Summary
-------

* Added checks for image file contents not matching the file extension (e.g. a bitmap named file.jpg).
* Added checks for abnormally short files to avoid crashes when parsing them.


This addresses bug STORM-1118.
    http://jira.secondlife.com/browse/STORM-1118


Diffs
-----

  indra/llimage/llimagedimensionsinfo.h 33ca961b0870 
  indra/llimage/llimagedimensionsinfo.cpp 33ca961b0870 

Diff: http://codereview.secondlife.com/r/255/diff


Testing
-------


Thanks,

Vadim

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110407/8997dc74/attachment.htm 


More information about the opensource-dev mailing list