[opensource-dev] Review Request: (STORM-1042) Disabled 'Save' button at the 'Create Landmark' panel

[Vadim ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/261/#review583
-----------------------------------------------------------

Ship it!


- Vadim


On April 11, 2011, 9:27 a.m., Seth ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/261/
> -----------------------------------------------------------
> 
> (Updated April 11, 2011, 9:27 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Fixed the inventory observers of newly added items.
> 
> The problem was caused by an outdated message name stored in LLInventoryObserver::mMessageName and not updated properly in LLInventoryModel::notifyObservers(). 
> The message name used in LLInventoryAddedObserver::changed() was the name of the message most recently passed by LLInventoryModel::notifyObservers(), instead of the name of the latest actually received message. Using the most recent message name in this case fixed the problem.
> 
> 
> This addresses bug STORM-1042.
>     http://jira.secondlife.com/browse/STORM-1042
> 
> 
> Diffs
> -----
> 
>   indra/newview/llinventorymodel.h d30636c2a83a 
>   indra/newview/llinventorymodel.cpp d30636c2a83a 
>   indra/newview/llinventorymodelbackgroundfetch.cpp d30636c2a83a 
>   indra/newview/llinventoryobserver.h d30636c2a83a 
>   indra/newview/llinventoryobserver.cpp d30636c2a83a 
> 
> Diff: http://codereview.secondlife.com/r/261/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Seth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110411/c353787f/attachment-0001.htm