[opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

[Jonathan Yap]

> On April 13, 2011, 7:19 a.m., Boroondas Gupte wrote:
> > indra/newview/llviewerchat.h, lines 37-39
> > <http://codereview.secondlife.com/r/244/diff/2-3/?file=1366#file1366line37>
> >
> >     Why repeat the 'public:' ?

Vadim's RB comments and other LL code implied this was the way to go.  I've just eliminated the extra public: line as it's only for one item.


> On April 13, 2011, 7:19 a.m., Boroondas Gupte wrote:
> > indra/newview/llviewerchat.h, line 38
> > <http://codereview.secondlife.com/r/244/diff/2-3/?file=1366#file1366line38>
> >
> >     Indented with 4 spaces instead of 1 tab like the other lines.

Fixed.


> On April 13, 2011, 7:19 a.m., Boroondas Gupte wrote:
> > doc/contributions.txt, line 646
> > <http://codereview.secondlife.com/r/244/diff/3/?file=1447#file1447line646>
> >
> >     I guess the STORM-1077 and STORM-1019 entries were added in error? Or why are you replacing them, rather than just adding STORM-1095?

I am not the best Merge Monkey and must have made an error when merging these changesets into viewer-development when the MM sent this back.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/244/#review589
-----------------------------------------------------------


On April 13, 2011, 6:40 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/244/
> -----------------------------------------------------------
> 
> (Updated April 13, 2011, 6:40 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
>  Chat preferences > font size should increase size of input text in the chat box
> 
> 
> This addresses bug STORM-1095.
>     http://jira.secondlife.com/browse/STORM-1095
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt a8f868007986 
>   indra/llui/lllineeditor.h a8f868007986 
>   indra/llui/lllineeditor.cpp a8f868007986 
>   indra/newview/llbottomtray.cpp a8f868007986 
>   indra/newview/llfloaterpreference.cpp a8f868007986 
>   indra/newview/llnearbychatbar.h a8f868007986 
>   indra/newview/llnearbychatbar.cpp a8f868007986 
>   indra/newview/llviewerchat.h a8f868007986 
>   indra/newview/llviewerchat.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/244/diff
> 
> 
> Testing
> -------
> 
> Change font size in preferences and see
> 1) Font size in chat input box changes to new size immediately
> 2) Font size is set to selected size when viewer is restarted
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110413/0bd98125/attachment.htm