[opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

Vadim ProductEngine vsavchuk at productengine.com
Wed Apr 13 13:26:44 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/262/#review598
-----------------------------------------------------------

Ship it!


No major objections.


indra/newview/llfloaterworldmap.cpp
<http://codereview.secondlife.com/r/262/#comment552>

    CS: sim_info_vec



indra/newview/llfloaterworldmap.cpp
<http://codereview.secondlife.com/r/262/#comment557>

    I'd move the iterator declaration inside the "for" clause to limit its scope.


- Vadim


On April 13, 2011, 12:16 p.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/262/
> -----------------------------------------------------------
> 
> (Updated April 13, 2011, 12:16 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> The results of using the World Map search option are sorted.
> 
> 
> This addresses bug Storm-1128.
>     http://jira.secondlife.com/browse/Storm-1128
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt a8f868007986 
>   indra/newview/llfloaterworldmap.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/262/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110413/c00b8d24/attachment.htm 


More information about the opensource-dev mailing list