[opensource-dev] Review Request: fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)7

[Xiaohong Bao]

> On April 8, 2011, 3:48 p.m., Boroondas Gupte wrote:
> > indra/newview/llviewertexturelist.h, line 191
> > <http://codereview.secondlife.com/r/252/diff/1/?file=1406#file1406line191>
> >
> >     Any reason for this to be BOOL instead of bool?
> >     Also, remove the space between the name and the semicolon.

BOOL is one byte, easy for memory alignment.


> On April 8, 2011, 3:48 p.m., Boroondas Gupte wrote:
> > indra/newview/llviewertexturelist.cpp, lines 91-93
> > <http://codereview.secondlife.com/r/252/diff/1/?file=1407#file1407line91>
> >
> >     I guess the intention is that this gets only executed by one single thread. (And probably only once?) So before setting sRenderThreadID to the current thread's ID, we might want to assert that it hasn't been changed before (i.e., is still 0).
> >     
> >     (If we want to allow to execute this assignment several times but only by one thread, check whether it's 0 or already has the value of LLThread::currentID().)

does not need to because that function is called only in the main thread.


- Xiaohong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/252/#review567
-----------------------------------------------------------


On April 8, 2011, 10:26 a.m., Xiaohong Bao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/252/
> -----------------------------------------------------------
> 
> (Updated April 8, 2011, 10:26 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> this is to resubmit the patch for storm-973.
> 
> We are not very clear what causes this. But this fix is targeting three most possible causes:
> 1, a texture is failed to add into mImageList but its flag is set to be successful;
> 2, a texture status is changed not from the main thread, because gTextureList is not thread-safe;
> 3, gTextureList is accessed before it is initialized.
> 
> I regenerated the viewer-development-storm-973 branch based on the latest viewer-development branch. If you still can not apply the patch directly, I am afraid you should do the manual merge. Otherwise grant me the permission, I will do it. 
> 
> 
> This addresses bug storm-973.
>     http://jira.secondlife.com/browse/storm-973
> 
> 
> Diffs
> -----
> 
>   indra/newview/lldrawpoolbump.cpp 13670741a0a8 
>   indra/newview/llviewertexturelist.h 13670741a0a8 
>   indra/newview/llviewertexturelist.cpp 13670741a0a8 
> 
> Diff: http://codereview.secondlife.com/r/252/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Xiaohong
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110414/a7c70ac8/attachment.htm