[opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

[Twisted Laws]

> On April 14, 2011, 1:01 p.m., Vadim ProductEngine wrote:
> > indra/newview/skins/default/xui/en/menu_people_nearby_view_sort.xml, line 45
> > <http://codereview.secondlife.com/r/265/diff/1/?file=1474#file1474line45>
> >
> >     I'd say "View Mini-Map": by "Map" we usually mean the world map, which is obviously a different thing.

I was making the other changes mentioned in the reviews, but this one I question...  imho, putting in View Mini-Map is misleading also as a requirement of implementation was to leave the mini-map available seperately.  I would not consider this the "mini-map".  But I'm open to have it however you (as a Linden) want it.


- Twisted


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/265/#review603
-----------------------------------------------------------


On April 14, 2011, 5:29 a.m., Twisted Laws wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/265/
> -----------------------------------------------------------
> 
> (Updated April 14, 2011, 5:29 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Patch makes the map in the Nearby people tab optional with a menu option in the gear 
> menu.  Patch is XML only and resizing of the map is disabled (user_resize="false" in 
> the layout_panels) as I could not find a way to easily save window sizes purely in XML.
> Patch is in the repository of https://Twisted_Laws/viewer-development-storm-1103 as
> https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/3455e79a14af
> 
> 
> This addresses bug STORM-1103.
>     http://jira.secondlife.com/browse/STORM-1103
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt ee4d271eef9b 
>   indra/newview/app_settings/settings.xml ee4d271eef9b 
>   indra/newview/skins/default/xui/en/menu_people_nearby_view_sort.xml ee4d271eef9b 
>   indra/newview/skins/default/xui/en/panel_people.xml ee4d271eef9b 
> 
> Diff: http://codereview.secondlife.com/r/265/diff
> 
> 
> Testing
> -------
> 
> Tested by exercising the gear menu option of "View Map" with the People tab attached 
> and detached insuring the map appears and disappears properly.
> 
> 
> Thanks,
> 
> Twisted
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110415/70ec7588/attachment.htm