[opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional
Boroondas Gupte
sllists at boroon.dasgupta.ch
Fri Apr 15 12:43:10 PDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/265/#review621
-----------------------------------------------------------
Ship it!
indra/newview/skins/default/xui/en/panel_people.xml
<http://codereview.secondlife.com/r/265/#comment590>
Put a space before the "/>" and it's perfect, I'd say.
(I cannot tell whether all the numbers for the positioning attributes make sense, but I guess you would have noticed while testing if not.)
- Boroondas
On April 15, 2011, 11:46 a.m., Twisted Laws wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/265/
> -----------------------------------------------------------
>
> (Updated April 15, 2011, 11:46 a.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> Patch makes the map in the Nearby people tab optional with a menu option in the gear
> menu. Patch is XML only and resizing of the map is disabled (user_resize="false" in
> the layout_panels) as I could not find a way to easily save window sizes purely in XML.
> Patch is in the repository of https://Twisted_Laws/viewer-development-storm-1103 as
> https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/3455e79a14af
>
>
> This addresses bug STORM-1103.
> http://jira.secondlife.com/browse/STORM-1103
>
>
> Diffs
> -----
>
> doc/contributions.txt ee4d271eef9b
> indra/newview/app_settings/settings.xml ee4d271eef9b
> indra/newview/skins/default/xui/en/menu_people_nearby_view_sort.xml ee4d271eef9b
> indra/newview/skins/default/xui/en/panel_people.xml ee4d271eef9b
>
> Diff: http://codereview.secondlife.com/r/265/diff
>
>
> Testing
> -------
>
> Tested by exercising the gear menu option of "View Map" with the People tab attached
> and detached insuring the map appears and disappears properly.
>
>
> Thanks,
>
> Twisted
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110415/2ac4e2f6/attachment.htm
More information about the opensource-dev
mailing list