[opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

[Jonathan Yap]

> On April 16, 2011, 12:37 p.m., Boroondas Gupte wrote:
> > indra/newview/llfloaterworldmap.cpp, line 92
> > <http://codereview.secondlife.com/r/262/diff/3/?file=1486#file1486line92>
> >
> >     Consider replacing the type notation
> >     	const std::pair <U64, LLSimInfo*>&
> >     be the (equivalent!) notation
> >     	std::pair <U64, LLSimInfo*> const&
> >     which, although less 'traditional', is IMO easier to understand. (See http://www.xs4all.nl/~carlo17/cpp/const.qualifier.html )

Changed.


> On April 16, 2011, 12:37 p.m., Boroondas Gupte wrote:
> > indra/newview/llfloaterworldmap.cpp, line 1500
> > <http://codereview.secondlife.com/r/262/diff/3/?file=1486#file1486line1500>
> >
> >     If we use std::sort, we really should directly #include <algorithm> in this file, even if it already gets included indirectly (via other includes). The only exception I'd make would be if <algorithm> was already (directly) included by the corresponding header file, indra/newview/llfloaterworldmap.h, but that isn't the case here.

Good observation.  Changed.


> On April 16, 2011, 12:37 p.m., Boroondas Gupte wrote:
> > indra/newview/llfloaterworldmap.cpp, line 88
> > <http://codereview.secondlife.com/r/262/diff/3/?file=1486#file1486line88>
> >
> >     remove trailing whitespace

Changed.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/262/#review629
-----------------------------------------------------------


On April 16, 2011, 6:24 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/262/
> -----------------------------------------------------------
> 
> (Updated April 16, 2011, 6:24 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> The results of using the World Map search option are sorted.
> 
> 
> This addresses bug Storm-1128.
>     http://jira.secondlife.com/browse/Storm-1128
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt a8f868007986 
>   indra/newview/llfloaterworldmap.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/262/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110416/53d057e1/attachment.htm