[opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network
Ima Mechanique
Ima.Mechanique at blueyonder.co.uk
Tue Apr 19 20:00:03 PDT 2011
> On April 19, 2011, 8:02 a.m., Vadim ProductEngine wrote:
> > Could you please provide the patch description? I.e what the problem was and how you fixed it.
I'm not sure what you want here.
If you're asking what I did? I updated Kitty's two line patch to apply against the current code, then tested that it fixed the problem.
If you're asking what Kitty's thinking was behind the solution? I can't answer that.
- Ima
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/271/#review631
-----------------------------------------------------------
On April 19, 2011, 7:57 a.m., Ima Mechanique wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/271/
> -----------------------------------------------------------
>
> (Updated April 19, 2011, 7:57 a.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> Applying Kitty Barnett's patch against current code base.
>
>
> This addresses bug STORM-1175.
> http://jira.secondlife.com/browse/STORM-1175
>
>
> Diffs
> -----
>
> doc/contributions.txt 584211e99147
> indra/llui/llnotifications.cpp 584211e99147
>
> Diff: http://codereview.secondlife.com/r/271/diff
>
>
> Testing
> -------
>
> Release build. tested preferences both in world and on the log in screen.
>
>
> Thanks,
>
> Ima
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110420/097b16fa/attachment.htm
More information about the opensource-dev
mailing list