[opensource-dev] Review Request: OPEN-61 Adding locations that VC redistributable package installs files.

[Nicky Perian]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/259/#review645
-----------------------------------------------------------

Ship it!


Works Great!

- Nicky


On April 21, 2011, 2:18 p.m., Ima Mechanique wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/259/
> -----------------------------------------------------------
> 
> (Updated April 21, 2011, 2:18 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> The VC redistributable package installs its files (msvcr100.dll, msvcp100.dll, msvcr100d.dll, msvcp100d.dll, etc.) to the WINDOWS\System32 directory (and WINDOWS\SysWOW64, if it is a 64-bit version). Adding these locations to the list of places to look when attempting to copy the files to build-vc100\sharedlibs.
> 
> On 64 bit windows the 32-bit file versions go to SySWOW64, so this is listed first to prevent the 64-bit versions being used.
> 
> If any one knows how it could use %systemroot% instead of the environment variable WINDIR I'd appreciate the info ;-) 
> 
> 
> This addresses bug OPEN-61.
>     http://jira.secondlife.com/browse/OPEN-61
> 
> 
> Diffs
> -----
> 
>   indra/cmake/Copy3rdPartyLibs.cmake 33ca961b0870 
> 
> Diff: http://codereview.secondlife.com/r/259/diff
> 
> 
> Testing
> -------
> 
> Ran 'autobuild build' without manually copying the redistributable files or adding the configure switch to point at their location.
> 
> 
> Thanks,
> 
> Ima
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110422/b00c936b/attachment.htm