[opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

Vadim ProductEngine vsavchuk at productengine.com
Mon Apr 25 10:27:48 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/277/#review647
-----------------------------------------------------------

Ship it!


Looks good, thanks.

One note that applies to my patch as well: rfind() seems to fit better than find() in this case.

- Vadim


On April 25, 2011, 5:09 a.m., Boroondas Gupte wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/277/
> -----------------------------------------------------------
> 
> (Updated April 25, 2011, 5:09 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Just looked at Vadim's fix for Linux in lldir_linux.cpp (also in this review request's diff) and applied analogous changes to lldir_mac.cpp, in hope that this would fix the same issue on Mac, too:
> * renamed indra_pos to build_dir_pose (just for consistency. This should not have any effect.)
> * search for "/build-darwin-" rather than "/indra" within mExecutableDir (The new build dir prefix is taken from .hgignore, in the hope that is up to date.)
> 
> 
> This addresses bug STORM-1182.
>     http://jira.secondlife.com/browse/STORM-1182
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 9c0506d10226 
>   indra/llvfs/lldir_linux.cpp 9c0506d10226 
>   indra/llvfs/lldir_mac.cpp 9c0506d10226 
> 
> Diff: http://codereview.secondlife.com/r/277/diff
> 
> 
> Testing
> -------
> 
> None, as I don't have a mac.
> 
> 
> Thanks,
> 
> Boroondas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110425/58d95975/attachment-0001.htm 


More information about the opensource-dev mailing list