[opensource-dev] Review Request: CHOP-629 symbol information for llcommon.dll is missing both in the debugger and in crash reports

[Boroondas Gupte]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/281/#review653
-----------------------------------------------------------



indra/llcommon/CMakeLists.txt
<http://codereview.secondlife.com/r/281/#comment613>

    Naive question: Is there a reason not to add /DEBUG also when NOT LLCOMMON_LINK_SHARED?


- Boroondas


On April 26, 2011, 5:48 p.m., Brad Kittenbrink wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/281/
> -----------------------------------------------------------
> 
> (Updated April 26, 2011, 5:48 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Somewhere in the VS2010 transition, the default conventions changed for how .pdb files get generated on shared library targets.  This fix explicitly sets the /DEBUG flag for the linker on the llcommon target.
> 
> 
> This addresses bug CHOP-629.
>     http://jira.secondlife.com/browse/CHOP-629
> 
> 
> Diffs
> -----
> 
>   indra/llcommon/CMakeLists.txt UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/281/diff
> 
> 
> Testing
> -------
> 
> I tested locally in the debugger, but I did not test crash reports.  We should find a way to test that once my TC build completes.
> 
> 
> Thanks,
> 
> Brad
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110427/41350882/attachment.htm