[opensource-dev] Review Request: STORM-1093 "Dock" icon is still shown after a side panel has been docked with Ctrl+Shift+W

[Merov Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/276/#review662
-----------------------------------------------------------

Ship it!


Looks correct. Definitely needs a PO build to confirm it doesn't break anything.

- Merov


On April 22, 2011, 9:06 a.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/276/
> -----------------------------------------------------------
> 
> (Updated April 22, 2011, 9:06 a.m.)
> 
> 
> Review request for Viewer and Richard Nelson.
> 
> 
> Summary
> -------
> 
> Reason:
> When an undocked side tray tab floater got closed with Ctrl+Shift+W,
> LLSideTray::setTabDocked() was called. It docked the floater but didn't update
> the dock/undock icon.
> 
> Fix:
> Made setTabDocked() a general purpose method, not a hack suitable for using
> only as a floater close callback in the basic viewer mode.
> It now updates the dock/undock icon.
> 
> Other changes:
> * Replaced numerous calls to toggleTabDocked with setDocked(),
>   that is safer because does exactly what you want.
> * Got rid of a duplicated floater close callback.
> 
> 
> This addresses bug STORM-1093.
>     http://jira.secondlife.com/browse/STORM-1093
> 
> 
> Diffs
> -----
> 
>   indra/newview/llfloatersidetraytab.cpp UNKNOWN 
>   indra/newview/llsidetray.h UNKNOWN 
>   indra/newview/llsidetray.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/276/diff
> 
> 
> Testing
> -------
> 
> Testing (un)docking side tray tabs in Basic and Advanced viewer modes.
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110428/e925a760/attachment-0001.htm