[opensource-dev] Review Request: STORM-1186 "no mCurrentRMessageTemplate" spam when first opening inventory

[ArminWeatherHax Resident]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/425/#review945
-----------------------------------------------------------

Ship it!


- ArminWeatherHax


On Aug. 1, 2011, 11:41 a.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/425/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2011, 11:41 a.m.)
> 
> 
> Review request for Viewer, Stone Linden and Richard Nelson.
> 
> 
> Summary
> -------
> 
> Removed the "no mCurrentRMessageTemplate" warning message.
> 
> The mCurrentRMessageTemplate member seems to only be non-NULL for a short while
> after an incoming message was validated and parsed, thus there is no
> guarantee that we can obtain name of the last received message at any given
> time. So if we can't we'll simply return an empty string without spamming the
> log with warnings.
> 
> The issue may have been introduced in changeset https://bitbucket.org/lindenlab/viewer-development/changeset/354916d6f13c.
> 
> 
> This addresses bug STORM-1186.
>     http://jira.secondlife.com/browse/STORM-1186
> 
> 
> Diffs
> -----
> 
>   indra/llmessage/lltemplatemessagereader.cpp ac0f1a132d35 
> 
> Diff: http://codereview.secondlife.com/r/425/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110801/b62177b9/attachment.htm