[opensource-dev] Review Request: STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)

[Boroondas Gupte]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/432/#review953
-----------------------------------------------------------


Thanks for looking into this. I've stopped counting how often I've crashed due to this.

> Apparently, passing empty region name to the MapNameRequest makes server return
> empty name in MapBlockReply, which triggered the assertion.

Shouldn't we warn rather than assert when we receive invalid (or just useless) data from remote (whether by our own or the servers' fault)? I don't think any service should be given the power to 'shoot down' the viewer.


indra/newview/llfloaterworldmap.cpp
<http://codereview.secondlife.com/r/432/#comment979>

    Instead of returning early ...



indra/newview/llfloaterworldmap.cpp
<http://codereview.secondlife.com/r/432/#comment980>

    ... you could wrap the remainder of the method into a conditional block.


- Boroondas


On Aug. 5, 2011, 1:34 p.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/432/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2011, 1:34 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Fixed a debug assertion triggered in the world map floater.
> 
> Apparently, passing empty region name to the MapNameRequest makes server return
> empty name in MapBlockReply, which triggered the assertion.
> 
> 
> Diffs
> -----
> 
>   indra/newview/llfloaterworldmap.cpp 0fd2a1181a96 
> 
> Diff: http://codereview.secondlife.com/r/432/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110805/1bdc1c5b/attachment-0001.htm