[opensource-dev] Review Request: STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)

[Boroondas Gupte]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/432/#review959
-----------------------------------------------------------

Ship it!


> The assert will not be in issue for release builds.
> Triggering it in debug builds help catching bugs, as in this case.
> Besides, the assert was added in attempt to locate another bug (EXT-4568), so I'd just leave it.

Sounds reasonable.

- Boroondas


On Aug. 5, 2011, 1:34 p.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/432/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2011, 1:34 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Fixed a debug assertion triggered in the world map floater.
> 
> Apparently, passing empty region name to the MapNameRequest makes server return
> empty name in MapBlockReply, which triggered the assertion.
> 
> 
> Diffs
> -----
> 
>   indra/newview/llfloaterworldmap.cpp 0fd2a1181a96 
> 
> Diff: http://codereview.secondlife.com/r/432/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110808/ec9bf3e9/attachment.htm