[opensource-dev] Review Request: /me emote doubles name in chat history

[Vadim ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/419/#review962
-----------------------------------------------------------


The patch introduces regressions:
* The /me prefix is not handled in IMs.
* In non-plain text nearby chat the /me prefix is removed completely, i.e. not replaced with a name.


indra/newview/llchathistory.cpp
<http://codereview.secondlife.com/r/419/#comment989>

    Agree with Boroondas that replacing /me with the sender name and then stripping it looks weird.


- Vadim


On July 27, 2011, 8:52 p.m., ardy.lay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/419/
> -----------------------------------------------------------
> 
> (Updated July 27, 2011, 8:52 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> As a resident of Second Life I find the displaying an emoter's name twice in nearby chat history rather unnecessary.  Please lay eyes on this proposed code change and let me know what you think.
> 
> I took care to remove the unlinked sender name instead of the linked one.
> 
> 
> This addresses bug VWR-26393.
>     http://jira.secondlife.com/browse/VWR-26393
> 
> 
> Diffs
> -----
> 
>   indra/newview/llchathistory.cpp 2f9a87538ca1 
> 
> Diff: http://codereview.secondlife.com/r/419/diff
> 
> 
> Testing
> -------
> 
> Tell a crowd what you are testing and many will start talking to you prefixed with /me, if they are good sports.  I have been using this change for 3 days now and have not noticed any ill effects.  Please note: This changest is not intended to affect nearby chat toasts, nearby chat log files, IM history, IM toasts or IM log files.
> 
> 
> Thanks,
> 
> ardy.lay
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110811/b39faecf/attachment.htm