[opensource-dev] Review Request: STORM-632 URL-like resident display name is shown as clickable HTTP URL in various places (additional fix)

[Richard Nelson]

> On Aug. 11, 2011, 12:29 p.m., Richard Nelson wrote:
> > indra/llui/llurlentry.cpp, line 1137
> > <http://codereview.secondlife.com/r/433/diff/1/?file=6909#file6909line1137>
> >
> >     This regexp will not allow nested tags.  I'm not sure if we can handle or use nested tags, but it would seem to be better to use:
> >     
> >     boost::regex("<nolink>.?</nolink>")
> >     
> >     this will consume as few characters as possible between the opening and closing tags, thus allowing multiple "nolink"s
> 
> Vadim ProductEngine wrote:
>     If I'm not mistaken, this regexp would not allow more than one character between the tags.

You are right, I meant .*?


- Richard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/433/#review963
-----------------------------------------------------------


On Aug. 10, 2011, 8:25 a.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/433/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2011, 8:25 a.m.)
> 
> 
> Review request for Viewer and Richard Nelson.
> 
> 
> Summary
> -------
> 
> Disallow showing URL-like avatar display names as Web links in the ShareItemsConfirmation notification.
> 
> Updating the <nolink> tag parsing regexp to enable multiple <nolink>...</nolink> clauses in a single textbox.
> 
> 
> This addresses bug STORM-632.
>     http://jira.secondlife.com/browse/STORM-632
> 
> 
> Diffs
> -----
> 
>   indra/llui/llurlentry.cpp 99a6889a65ec 
>   indra/newview/skins/default/xui/en/notifications.xml 99a6889a65ec 
> 
> Diff: http://codereview.secondlife.com/r/433/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110811/5743bd46/attachment-0001.htm