[opensource-dev] Review Request: /me emote doubles name in chat history

[Vadim ProductEngine]

> On Aug. 11, 2011, 11:47 a.m., Vadim ProductEngine wrote:
> > indra/newview/llchathistory.cpp, line 929
> > <http://codereview.secondlife.com/r/419/diff/1/?file=6814#file6814line929>
> >
> >     Agree with Boroondas that replacing /me with the sender name and then stripping it looks weird.
> 
> ardy.lay wrote:
>     I don't know how I missed that problem in IMs.  All I was trying to do was fix it in nearby chat history without breaking anything else.  I find that reverting one changeset gets me pretty close so I think I shall probably close and discard my own attempt here and ask for eyes on:
>      (741e44af9f02) ER-949:  Chat using '/me' style text displayed incorrectly.  Reviewed by Kelly
>     I backed that out and now I only see the local chat toasts displaying /me emotes incorrectly. What do you see?

Ardy, if you want my opinion, please provide a clean repo with single relevant changeset (so that there is no need to backout or strip anything) and post a review request.
Thank you.


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/419/#review962
-----------------------------------------------------------


On July 27, 2011, 8:52 p.m., ardy.lay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/419/
> -----------------------------------------------------------
> 
> (Updated July 27, 2011, 8:52 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> As a resident of Second Life I find the displaying an emoter's name twice in nearby chat history rather unnecessary.  Please lay eyes on this proposed code change and let me know what you think.
> 
> I took care to remove the unlinked sender name instead of the linked one.
> 
> 
> This addresses bug VWR-26393.
>     http://jira.secondlife.com/browse/VWR-26393
> 
> 
> Diffs
> -----
> 
>   indra/newview/llchathistory.cpp 2f9a87538ca1 
> 
> Diff: http://codereview.secondlife.com/r/419/diff
> 
> 
> Testing
> -------
> 
> Tell a crowd what you are testing and many will start talking to you prefixed with /me, if they are good sports.  I have been using this change for 3 days now and have not noticed any ill effects.  Please note: This changest is not intended to affect nearby chat toasts, nearby chat log files, IM history, IM toasts or IM log files.
> 
> 
> Thanks,
> 
> ardy.lay
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110813/62744678/attachment-0001.htm