[opensource-dev] Questions about unit test for "hg policy" (was: Mercurial hook checking for well-formed XML)

Boroondas Gupte sllists at boroon.dasgupta.ch
Tue Aug 16 14:25:00 PDT 2011


Heya Oz

Thanks for making Bos' hg hooks public!

I've looked at the unit test you've written for hg policy and have two
questions about it:

   1. Is it by purpose that the return code isn't checked after the hg
      policy invocation on line 23
      <https://bitbucket.org/lindenlab/hg-tools/src/5ddf6f780503/tests/test-policies#cl-23>?
   2. On lines 75
      <https://bitbucket.org/lindenlab/hg-tools/src/5ddf6f780503/tests/test-policies#cl-75>-77,
      is there a reason why you use cp rather than mv? I think the
      latter would avoid the need for the subsequent rm.

Cheers,
Boroondas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110816/31d67aaa/attachment-0001.htm 


More information about the opensource-dev mailing list