[opensource-dev] Review Request: STORM-1041 Removed clothes come back to haunt me

[Nyx Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/441/#review981
-----------------------------------------------------------

Ship it!


I was skeptical, but after reviewing some of the code from those systems (that I hadn't touched in months), the proposed code appears to be correct. Also tested the build and it appears functional. Ship it!

- Nyx


On Aug. 15, 2011, 12:26 p.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/441/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2011, 12:26 p.m.)
> 
> 
> Review request for Viewer and Nyx Linden.
> 
> 
> Summary
> -------
> 
> The "Remove all clothes" item of the avatar menu didn't actually remove all clothes.
> 
> I haven't investigated what the problem was, I've just rewritten the (ancient?) removal code
> in the way we take off items in other places, i.e. by removing them from the Current Outfit forder.
> 
> What I'm not sure about is whether we need to call updateAppearanceFromCOF() afterwards. Nyx?
> 
> 
> This addresses bug STORM-1041.
>     http://jira.secondlife.com/browse/STORM-1041
> 
> 
> Diffs
> -----
> 
>   indra/newview/llagentwearables.h 87fe21031c46 
>   indra/newview/llagentwearables.cpp 87fe21031c46 
>   indra/newview/llinventorybridge.cpp 87fe21031c46 
> 
> Diff: http://codereview.secondlife.com/r/441/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110817/0f5cf57d/attachment.htm