[opensource-dev] Review Request: STORM-1268 Viewer update resets some viewer settings

Vadim ProductEngine vsavchuk at productengine.com
Fri Aug 19 03:55:32 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/443/
-----------------------------------------------------------

Review request for Viewer and Richard Nelson.


Summary
-------

Bug:
Settings for ignorable dialogs were reset during deferred auto-upgrade.

Reason:
In case of deferred upgrade (i.e. when you select "Later...") the defaults for notifications settings are not loaded,
so when the viewer exits after launching the updater, it incorrectly re-saves notifications settings.

Fix:
Initialize settings earlier, so that viewer picks them up in update mode.


This addresses bug STORM-1268.
    http://jira.secondlife.com/browse/STORM-1268


Diffs
-----

  indra/newview/llappviewer.cpp 478aabd2813b 

Diff: http://codereview.secondlife.com/r/443/diff


Testing
-------

See acceptance criteria in the JIRA ticket.


Thanks,

Vadim

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110819/fc71cc1a/attachment.htm 


More information about the opensource-dev mailing list