[opensource-dev] Review Request: STORM-1543 During busy mode inventory offers get silently deleted instead of thrown into trash

Vadim ProductEngine vsavchuk at productengine.com
Fri Aug 19 10:06:03 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/444/
-----------------------------------------------------------

Review request for Viewer and Richard Nelson.


Summary
-------

In busy mode offered inventory items are now moved to trash.

There were two bugs:

1. When auto-discarding inventory offers we looked up missing Busy button
(i.e. a button having index=3) in the inventory offer notification dialog
template. Failure to find the button resulted in ignoring inventory offers.

Fixed that by "auto-clicking" the existing Discard button.

2. It turned out impossible to properly remove an inventory item
from within LLDiscardAgentOffer::done(), because that would lead to
nested LLInventoryModel::notifyObservers() calls.

Fixed that by deferring removal until the next LLAppViewer::idle() iteration.


This addresses bug STORM-1543.
    http://jira.secondlife.com/browse/STORM-1543


Diffs
-----

  indra/newview/llappviewer.h 478aabd2813b 
  indra/newview/llappviewer.cpp 478aabd2813b 
  indra/newview/llviewermessage.cpp 478aabd2813b 

Diff: http://codereview.secondlife.com/r/444/diff


Testing
-------


Thanks,

Vadim

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110819/0aa4e222/attachment.htm 


More information about the opensource-dev mailing list