[opensource-dev] Review Request: STORM-1543 During busy mode inventory offers get silently deleted instead of thrown into trash

[Richard Nelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/444/#review990
-----------------------------------------------------------



indra/newview/llviewermessage.cpp
<http://codereview.secondlife.com/r/444/#comment1005>

    since we don't set IOR_BUSY anywhere (and its not a valid response in any notification), let's delete the IOR_BUSY value altogether and replace this line with
    
    BOOL busy = gAgent.getBusy();
    
    That will be a lot less confusing to the next person who needs to touch this code.


- Richard


On Aug. 22, 2011, 4:10 a.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/444/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2011, 4:10 a.m.)
> 
> 
> Review request for Viewer and Richard Nelson.
> 
> 
> Summary
> -------
> 
> In busy mode offered inventory items are now moved to trash.
> 
> There were two bugs:
> 
> 1. When auto-discarding inventory offers we looked up missing Busy button
> (i.e. a button having index=3) in the inventory offer notification dialog
> template. Failure to find the button resulted in ignoring inventory offers.
> 
> Fixed that by "auto-clicking" the existing Discard button.
> 
> 2. It turned out impossible to properly remove an inventory item
> from within LLDiscardAgentOffer::done(), because that would lead to
> nested LLInventoryModel::notifyObservers() calls.
> 
> Fixed that by deferring removal until the next LLAppViewer::idle() iteration.
> 
> 
> This addresses bug STORM-1543.
>     http://jira.secondlife.com/browse/STORM-1543
> 
> 
> Diffs
> -----
> 
>   indra/newview/llappviewer.h 7dbd8eaefaec 
>   indra/newview/llappviewer.cpp 7dbd8eaefaec 
>   indra/newview/llviewermessage.cpp 7dbd8eaefaec 
> 
> Diff: http://codereview.secondlife.com/r/444/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110823/3bec4f4c/attachment.htm