[opensource-dev] Review Request: STORM-1566 Sidebar windows no longer detach by right-clicking the tab

Seth ProductEngine slitovchuk at productengine.com
Thu Aug 25 13:36:13 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/447/#review991
-----------------------------------------------------------

Ship it!


Looks good to me.

- Seth


On Aug. 22, 2011, 8:08 a.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/447/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2011, 8:08 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Reason: wrong name was used to look up the tab to detach.
> 
> The regression was introduced in the fix of EXP-856 (changeset 9e650f2750b5).
> 
> 
> This addresses bug STORM-1566.
>     http://jira.secondlife.com/browse/STORM-1566
> 
> 
> Diffs
> -----
> 
>   indra/newview/llsidetray.cpp 6e3de80dc3a1 
> 
> Diff: http://codereview.secondlife.com/r/447/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110825/94ef9c5c/attachment.htm 


More information about the opensource-dev mailing list