[opensource-dev] Review Request: STORM-638 "Object Return" doesn't return distant objects

[Richard Nelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/451/#review997
-----------------------------------------------------------



indra/newview/llviewermenu.cpp
<http://codereview.secondlife.com/r/451/#comment1016>

    This is dangerous!  Never hold on to raw pointers to llviewerobject, as they can be deleted from under you.  Use LLPointer instead.
    
    I looked into fixing the underlying problem, but that involves revisiting the design of selections.  We always deselect objects beyond a certain distance in order to keep your avatar proximate to the objects you can affect (for various technical and social reasons).  This workaround is fine for now, if not ideal.


- Richard


On Aug. 26, 2011, 8:38 a.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/451/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2011, 8:38 a.m.)
> 
> 
> Review request for Viewer and Seth ProductEngine.
> 
> 
> Summary
> -------
> 
> Reason: Showing the confirmation dialog resets object selection,
> thus there is nothing to derez.
> 
> Fix: Save selection until user answers in the confirmation dialog.
> 
> I didn't investigate why the bug occurred only for distant object
> (must be some internal LLSelectMgr magic).
> 
> 
> This addresses bug STORM-638.
>     http://jira.secondlife.com/browse/STORM-638
> 
> 
> Diffs
> -----
> 
>   indra/newview/llviewermenu.cpp 64ed6f9362af 
> 
> Diff: http://codereview.secondlife.com/r/451/diff
> 
> 
> Testing
> -------
> 
> See acceptance criteria in the JIRA ticket.
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110826/dcbf1d20/attachment-0001.htm