[opensource-dev] Review Request: STORM-638 "Object Return" doesn't return distant objects
Vadim ProductEngine
vsavchuk at productengine.com
Sat Aug 27 03:01:27 PDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/451/
-----------------------------------------------------------
(Updated Aug. 27, 2011, 3:01 a.m.)
Review request for Viewer and Seth ProductEngine.
Changes
-------
Fixed a silly pointer usage mistake.
Summary
-------
Reason: Showing the confirmation dialog resets object selection,
thus there is nothing to derez.
Fix: Save selection until user answers in the confirmation dialog.
I didn't investigate why the bug occurred only for distant object
(must be some internal LLSelectMgr magic).
This addresses bug STORM-638.
http://jira.secondlife.com/browse/STORM-638
Diffs (updated)
-----
indra/newview/llviewermenu.cpp 00b00b942134
Diff: http://codereview.secondlife.com/r/451/diff
Testing
-------
See acceptance criteria in the JIRA ticket.
Thanks,
Vadim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110827/3f6ac7b4/attachment.htm
More information about the opensource-dev
mailing list