[opensource-dev] Review Request: STORM-1532 (was VWR-25923) followup: Unnecessary capability request spam

[Vadim ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/452/#review1003
-----------------------------------------------------------

Ship it!


Looks plausible to me.

- Vadim


On Aug. 30, 2011, 2:21 a.m., ArminWeatherHax Resident wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/452/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2011, 2:21 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> https://jira.secondlife.com/browse/STORM-1532 (was VWR-25923) this is a followup patch since  f7b7b211a33b (Fix for VOICE-3 [crashhunters] LLVoiceVoiceClient::stateMachine) already handles parts of the original patch. This patch avoids re-checking for the ParcelVoiceInfoRequest capability when its clear the region doesn't have it.
> 
> Armin
> 
> 
> This addresses bug STORM-1532.
>     http://jira.secondlife.com/browse/STORM-1532
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 478aabd2813b 
>   indra/newview/llvoicevivox.cpp 478aabd2813b 
> 
> Diff: http://codereview.secondlife.com/r/452/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> ArminWeatherHax
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110830/ba8f5ff7/attachment-0001.htm